fix: enable color on non-tty if color_enabled #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
see https://github.com/ku1ik/rainbow\?tab\=readme-ov-file\#advanced-usage preserves original behaviour of outputting color codes on non-tty/dumb terminals which caused failures in checking output when tested in gha via pact-ruby
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see https://github.com/ku1ik/rainbow\?tab\=readme-ov-file\#advanced-usage
preserves original behaviour of outputting color codes on non-tty/dumb terminals which caused failures in checking output when tested in gha via pact-ruby
relates to
finally fixes the failure, which led to the revert of the change, and will finally allow us to remove the term-ansicolor dep from pact 👍🏾