-
Notifications
You must be signed in to change notification settings - Fork 46
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: remove randexp dependency (#91)
- Loading branch information
1 parent
431733c
commit 794fd4e
Showing
2 changed files
with
5 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
794fd4e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The above change is actually preventing me to run the consumer pact tests from the github.com/pact-workshop-go
2021/09/30 22:32:50 [ERROR] service: /Users/ankit/code/go/src/github.com/pact-workshop-go/pact/lib/vendor/ruby/2.2.0/gems/pact-support-1.16.9/lib/pact/reification.rb:1:in `require': cannot load such file -- expgen (LoadError)
This is the error trace:
'[ERROR] service: pact-workshop-go/pact/lib/vendor/ruby/2.2.0/gems/pact-support-1.16.9/lib/pact/reification.rb:1:in
require': cannot load such file -- expgen (LoadError) [ERROR] service: from pact-workshop-go/pact/lib/vendor/ruby/2.2.0/gems/pact-support-1.16.9/lib/pact/reification.rb:1:in
<top (required)>'[ERROR] service: from pact-workshop-go/pact/lib/vendor/ruby/2.2.0/gems/pact-support-1.16.9/lib/pact/matchers/matchers.rb:16:in
require' [ERROR] service: from pact-workshop-go/pact/lib/vendor/ruby/2.2.0/gems/pact-support-1.16.9/lib/pact/matchers/matchers.rb:16:in
<top (required)>'[ERROR] service: from pact-workshop-go/pact/lib/vendor/ruby/2.2.0/gems/pact-support-1.16.9/lib/pact/matchers.rb:1:in
require' [ERROR] service: from pact-workshop-go/pact/lib/vendor/ruby/2.2.0/gems/pact-support-1.16.9/lib/pact/matchers.rb:1:in
<top (required)>'[ERROR] service: from pact-workshop-go/pact/lib/vendor/ruby/2.2.0/gems/pact-mock_service-3.9.0/lib/pact/mock_service/request_handlers/interaction_replay.rb:1:in
require' [ERROR] service: from pact-workshop-go/pact/lib/vendor/ruby/2.2.0/gems/pact-mock_service-3.9.0/lib/pact/mock_service/request_handlers/interaction_replay.rb:1:in
<top (required)>'[ERROR] service: from pact-workshop-go/pact/lib/vendor/ruby/2.2.0/gems/pact-mock_service-3.9.0/lib/pact/mock_service/request_handlers.rb:5:in
require' [ERROR] service: from pact-workshop-go/pact/lib/vendor/ruby/2.2.0/gems/pact-mock_service-3.9.0/lib/pact/mock_service/request_handlers.rb:5:in
<top (required)>'[ERROR] service: from pact-workshop-go/pact/lib/vendor/ruby/2.2.0/gems/pact-mock_service-3.9.0/lib/pact/mock_service/app.rb:6:in
require' [ERROR] service: from pact-workshop-go/pact/lib/vendor/ruby/2.2.0/gems/pact-mock_service-3.9.0/lib/pact/mock_service/app.rb:6:in
<top (required)>'[ERROR] service: from pact-workshop-go/pact/lib/vendor/ruby/2.2.0/gems/pact-mock_service-3.9.0/lib/pact/mock_service/run.rb:2:in
require' [ERROR] service: from pact-workshop-go/pact/lib/vendor/ruby/2.2.0/gems/pact-mock_service-3.9.0/lib/pact/mock_service/run.rb:2:in
<top (required)>'[ERROR] service: from pact-workshop-go/pact/lib/vendor/ruby/2.2.0/gems/pact-mock_service-3.9.0/lib/pact/mock_service/cli.rb:31:in
require' [ERROR] service: from pact-workshop-go/pact/lib/vendor/ruby/2.2.0/gems/pact-mock_service-3.9.0/lib/pact/mock_service/cli.rb:31:in
service'[ERROR] service: from pact-workshop-go/pact/lib/vendor/ruby/2.2.0/gems/thor-1.1.0/lib/thor/command.rb:27:in
run' [ERROR] service: from pact-workshop-go/pact/lib/vendor/ruby/2.2.0/gems/thor-1.1.0/lib/thor/invocation.rb:127:in
invoke_command'[ERROR] service: from pact-workshop-go/pact/lib/vendor/ruby/2.2.0/gems/thor-1.1.0/lib/thor.rb:392:in
dispatch' [ERROR] service: from pact-workshop-go/pact/lib/vendor/ruby/2.2.0/gems/thor-1.1.0/lib/thor/base.rb:485:in
start'[ERROR] service: from pact-workshop-go/pact/lib/app/pact-mock-service.rb:15:in `
[ERROR] Expected server to start < 10s. Timed out waiting for Mock Server to start on port 50307 - are you sure it's running?
--- FAIL: TestClientPact_GetUser (0.01s)
--- FAIL: TestClientPact_GetUser/the_user_exists (0.00s)
client_pact_test.go:83: Error on Verify: Post http://localhost:50307/interactions: dial tcp [::1]:50307: connect: connection refused
794fd4e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The expgen gem needed to be a runtime dependency, not a development dependency. I've put out a new release with the fix. My bad for missing that in the PR.
794fd4e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the quick fix. I can verify that it's fixed.