Enable username retrival from secret #85
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minedetector
force-pushed
the
username-from-secret
branch
from
788450d to
79b23ef
Compare
This change allows the username to be fetched from a secret for both self-hosted or external databases This approach is copied from how the database password is configured
minedetector
force-pushed
the
username-from-secret
branch
from
79b23ef to
b28eddb
Compare
|
@ChrisJBurns Hey. We added a little improvement. Could you please have a look? |
|
@minedetector Thanks for the PR, I need to get some CI tests in before I look at this, this should allow us to have more assurance of the changes being made to any of the Postgres code as there are some finicky conditionals that tend to bite every time they are changed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows the username to be fetched from a secret for both self-hosted or external databases
This approach is copied from how the database password is configured