Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore extension suffixes if the interpreter is Python 2 #18

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

ian-hurst
Copy link
Contributor

@ian-hurst ian-hurst commented Oct 30, 2024

TODO:

  • Write new tests or update the old ones to cover new functionality.
  • Update doc-strings where appropriate.
  • Update or write new documentation in packit/packit.dev.

Fixes Issue 17

RELEASE NOTES BEGIN

Ignore extension suffixes if the interpreter is Python 2

RELEASE NOTES END

Copy link
Contributor

Copy link
Member

@nforro nforro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I have a few remarks.

rpm/__init__.py Outdated Show resolved Hide resolved
rpm/__init__.py Outdated Show resolved Hide resolved
rpm/__init__.py Outdated Show resolved Hide resolved
Copy link
Contributor

Copy link
Member

@nforro nforro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Just two nitpicks. The commit message should describe the changes, although it can also include a reference to a GitHub issue, such info is less than useful to someone reading the commit message in their offline local clone.

rpm/__init__.py Show resolved Hide resolved
@ian-hurst ian-hurst changed the title Fix Issue 17 Fix get_system_sitepackages_and_suffixes() on python 2.7 Oct 31, 2024
Copy link
Contributor

@ian-hurst
Copy link
Contributor Author

Great! Just two nitpicks. The commit message should describe the changes, although it can also include a reference to a GitHub issue, such info is less than useful to someone reading the commit message in their offline local clone.

Ok, should be set now. Thanks for the review again, and let me know if I should do anything else.

@nforro
Copy link
Member

nforro commented Oct 31, 2024

Thanks!

Fix get_system_sitepackages_and_suffixes() on systems where /usr/libexec/platform-python is python 2.7 (issue 17)

Commit message title shouldn't exceed 72 characters, and even though we don't enforce that limit, this is a bit too long. How about:

Fix `get_system_sitepackages_and_suffixes()` on systems where `platform-python` is Python 2

or maybe even:

Ignore extension suffixes if the interpreter is Python 2

I would skip the issue reference (it's in the PR description where it is actually relevant), but if you really want to include it, place it in the body, not title.

@ian-hurst ian-hurst changed the title Fix get_system_sitepackages_and_suffixes() on python 2.7 Ignore extension suffixes if the interpreter is Python 2 Oct 31, 2024
@ian-hurst
Copy link
Contributor Author

I would skip the issue reference (it's in the PR description where it is actually relevant), but if you really want to include it, place it in the body, not title.

Sure, updated

Copy link
Contributor

@nforro nforro added the mergeit Zuul, merge it! label Oct 31, 2024
Copy link
Contributor

Build succeeded (gate pipeline).
https://softwarefactory-project.io/zuul/t/packit-service/buildset/358c8f28cebb4d7cb95647364a6ca264

✔️ pre-commit SUCCESS in 1m 34s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit d66de56 into packit:main Oct 31, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergeit Zuul, merge it!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Import fails when /usr/libexec/platform-python is python 2.7
2 participants