-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore extension suffixes if the interpreter is Python 2 #18
Conversation
Build succeeded. ✔️ pre-commit SUCCESS in 1m 26s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I have a few remarks.
Build succeeded. ✔️ pre-commit SUCCESS in 1m 28s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Just two nitpicks. The commit message should describe the changes, although it can also include a reference to a GitHub issue, such info is less than useful to someone reading the commit message in their offline local clone.
Build succeeded. ✔️ pre-commit SUCCESS in 1m 29s |
Ok, should be set now. Thanks for the review again, and let me know if I should do anything else. |
Thanks!
Commit message title shouldn't exceed 72 characters, and even though we don't enforce that limit, this is a bit too long. How about:
or maybe even:
I would skip the issue reference (it's in the PR description where it is actually relevant), but if you really want to include it, place it in the body, not title. |
Sure, updated |
Build succeeded. ✔️ pre-commit SUCCESS in 1m 33s |
Build succeeded (gate pipeline). ✔️ pre-commit SUCCESS in 1m 34s |
d66de56
into
packit:main
TODO:
packit/packit.dev
.Fixes Issue 17
RELEASE NOTES BEGIN
Ignore extension suffixes if the interpreter is Python 2
RELEASE NOTES END