Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the typo on --resolve-bug argument #855

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cathay4t
Copy link

The correct argument for pull-from-upstream is --resolve-bug, not
--resolved-bugs.

The correct argument for `pull-from-upstream` is `--resolve-bug`, not
`--resolved-bugs`.

Signed-off-by: Gris Ge <[email protected]>
Copy link
Contributor

Copy link
Member

@lbarcziova lbarcziova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! But in the service, it is --resolved-bugs, so these occurrences are correct.

@cathay4t
Copy link
Author

Can we unify them somehow? If I follow the document when using packit CLI, I got unknown argument error, I can only get it right by reading code of packit cli.

@lbarcziova
Copy link
Member

@cathay4t yes, that's a good point, opened packit/packit#2281

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants