-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Utilise LocalProjectBuilder for LP initalisation #2449
Utilise LocalProjectBuilder for LP initalisation #2449
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
LocalProject and builder improvements Needed for packit/packit-service#2449 RELEASE NOTES BEGIN N/A RELEASE NOTES END Reviewed-by: Matej Focko Reviewed-by: Laura Barcziová
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
With this change, for copr builds also try to not clone the repo. Related to packit#2411
Build succeeded. ✔️ pre-commit SUCCESS in 2m 43s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Even the tests did not require massive changes...
+1 for trying this on stage
self._local_project = builder.build( | ||
git_project=self.project, | ||
working_dir=self.service_config.command_handler_work_dir, | ||
ref=self.metadata.git_ref, | ||
pr_id=self.metadata.pr_id, | ||
merge_pr=self.package_config.merge_pr_in_ci, | ||
git_url=CALCULATE, | ||
repo_name=CALCULATE, | ||
full_name=CALCULATE, | ||
namespace=CALCULATE, | ||
git_repo=( | ||
CALCULATE | ||
if self.require_git_repo_in_local_project | ||
else NOT_TO_CALCULATE | ||
), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely explicit what is going on here... Finally getting some fruits from work on all of this...;)
Build succeeded (gate pipeline). ✔️ pre-commit SUCCESS in 2m 30s |
aad797a
into
packit:main
With this change, for copr builds also try to not clone the repo.
Fixes #1955
Related to #2411
For now no release notes, I would like to see whether this will work on staging as intended.
RELEASE NOTES BEGIN
N/A
RELEASE NOTES END