Utilise LocalProjectBuilder for LP initalisation #2449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
softwarefactory-project-zuul bot
added a commit
to packit/packit
that referenced
this pull request
Jun 26, 2024
LocalProject and builder improvements Needed for packit/packit-service#2449 RELEASE NOTES BEGIN N/A RELEASE NOTES END Reviewed-by: Matej Focko Reviewed-by: Laura Barcziová
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
With this change, for copr builds also try to not clone the repo. Related to packit#2411
|
Build succeeded. ✔️ pre-commit SUCCESS in 2m 43s |
lachmanfrantisek
approved these changes
Jun 26, 2024
Comment on lines
+98
to
+112
| self._local_project = builder.build( | ||
| git_project=self.project, | ||
| working_dir=self.service_config.command_handler_work_dir, | ||
| ref=self.metadata.git_ref, | ||
| pr_id=self.metadata.pr_id, | ||
| merge_pr=self.package_config.merge_pr_in_ci, | ||
| git_url=CALCULATE, | ||
| repo_name=CALCULATE, | ||
| full_name=CALCULATE, | ||
| namespace=CALCULATE, | ||
| git_repo=( | ||
| CALCULATE | ||
| if self.require_git_repo_in_local_project | ||
| else NOT_TO_CALCULATE | ||
| ), |
There was a problem hiding this comment.
Nicely explicit what is going on here... Finally getting some fruits from work on all of this...;)
|
Build succeeded (gate pipeline). ✔️ pre-commit SUCCESS in 2m 30s |
softwarefactory-project-zuul
bot
merged commit aad797a
into
packit:main
4 checks passed
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, for copr builds also try to not clone the repo.
Fixes #1955
Related to #2411
For now no release notes, I would like to see whether this will work on staging as intended.
RELEASE NOTES BEGIN
N/A
RELEASE NOTES END