-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass Anitya #91
Pass Anitya #91
Conversation
Signed-off-by: Matej Focko <[email protected]>
Signed-off-by: Matej Focko <[email protected]>
Signed-off-by: Matej Focko <[email protected]>
Signed-off-by: Matej Focko <[email protected]>
Signed-off-by: Matej Focko <[email protected]>
Build succeeded. ✔️ pre-commit SUCCESS in 6m 25s |
Signed-off-by: Matej Focko <[email protected]>
Build succeeded. ✔️ pre-commit SUCCESS in 9m 35s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nicely factored out! 🚀
pass_to_service=False, | ||
) | ||
|
||
new_versions = nested_get(event, "message", "project", "upstream_versions") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how will this work if there are multiple new versions? Could you point me to the docs explaining these, e.g. "upstream_versions" vs "version" (and maybe add a comment with this link please)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good question, open for discussion IMO 😂 docs
I think this applies mainly to the upstreams that keep multiple running branches (like kernel, maybe Java (? even though they have separate RPM packages for that)).
OTOH this is something that I can see used with CentOS specifically, because if there are multiple major/minor releases maintained, user should be able to specify some tag filtering in sense of “I want to follow this branch instead of the latest one”.
Given this example, these are the relevant fields:
upstream_versions
: which are apparently the newly detected versionsstable_versions
: duh…versions
: all versions (including stable, newly detected and prereleases; literally all)old_version
(not relevant, but worth mentioning): latest fromversion
, CAN be prerelease
I think we'll need to adjust this in the Service…
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, got it, thanks for the explanation!
I think we'll need to adjust this in the Service
👍
When logging the unconfigured CentOS version update, correctly get the package name. Co-authored-by: Laura Barcziová <[email protected]>
Co-authored-by: Laura Barcziová <[email protected]>
7a22ac3
to
da21b17
Compare
Build succeeded. ✔️ pre-commit SUCCESS in 1m 34s |
Build succeeded (gate pipeline). ✔️ pre-commit SUCCESS in 1m 16s |
4e9af0f
into
packit:main
Related to packit/packit-service#2068