Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

verify RPMs using rpminspect #786

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

verify RPMs using rpminspect #786

wants to merge 4 commits into from

Conversation

lbarcziova
Copy link
Member

@lbarcziova lbarcziova commented May 22, 2023 •
edited
Loading

just verifying packit/packit.dev#607

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/f3aeb8af7f7249be9a7a2b86314df7bb

✔️ pre-commit SUCCESS in 2m 04s
✔️ ogr-tests-rpm SUCCESS in 11m 42s
✔️ ogr-tests-pip-deps SUCCESS in 11m 49s
✔️ ogr-reverse-dep-packit-tests SUCCESS in 19m 12s

@lbarcziova lbarcziova mentioned this pull request May 22, 2023
Closed
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/02f5e1fc141744edb9ce0da63e35e5a9

✔️ pre-commit SUCCESS in 2m 10s
✔️ ogr-tests-rpm SUCCESS in 12m 00s
✔️ ogr-tests-pip-deps SUCCESS in 11m 58s
✔️ ogr-reverse-dep-packit-tests SUCCESS in 20m 41s

@mfocko
Copy link
Member

mfocko commented May 29, 2023 

�[33m[10:42:14] [W] [worker_1] [Fedora-38:x86_64:/plans/rpminspect.fedora] Could not find results file 'work-rpminspect.fedorapxjxl6_l/plans/rpminspect.fedora/execute/results.yaml' containing tmt results�[0m

What?

@lbarcziova
Copy link
Member Author

/packit-stg test

@LecrisUT
Copy link

LecrisUT commented Jun 6, 2023

Btw, for rpmlint of both spec and rpm files (rpmlint -r *.rpmlintrc ./*.spec /tmp/*.rpm as it is done downstream) you might need to add a configure file, e.g.:

$ cat packit.toml
Filters = [
    "unknown-key",
]
$ rpmlint -c packit.toml -r *.rpmlintrc ./*.spec /tmp/*.rpm

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/5f18be82226b46b081c2d93b8021e1f3

✔️ pre-commit SUCCESS in 2m 06s
✔️ ogr-tests-rpm SUCCESS in 11m 48s
✔️ ogr-tests-pip-deps SUCCESS in 11m 55s
✔️ ogr-reverse-dep-packit-tests SUCCESS in 19m 05s

@mfocko
Copy link
Member

mfocko commented Jun 23, 2023

/packit test

LecrisUT
LecrisUT reviewed Jun 23, 2023
View reviewed changes
plans/rpminspect-centos.fmf Outdated
- rpminspect
- rpminspect-data-centos
- how: shell
script: cd /tmp && curl -O ${PACKIT_SRPM_URL}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
script: cd /tmp && curl -O ${PACKIT_SRPM_URL}
script: dnf download ${PACKIT_COPR_RPMS} --destdir=$TMT_PLAN_DATA

A simpler one-liner, and then in tests, change the path accordingly. Should be more robust against future environment changes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, I think we wanted to avoid downloading the RPMs ourselves and leave this to TF itself, as looking into packit/packit.dev#607

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure I understand this. You mean to not use ${PACKIT_COPR_RPMS} or to have them available on TF by default? Would this still be reproducable locally via the testing farm link?

Copy link
Member

@lachmanfrantisek lachmanfrantisek Jul 11, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just an alternative way how to download RPMs without changing anything else. So we should be fine with this approach.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe, the only downside might be the lack of DNF on some systems.

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/904eb6465f9a433b81d56d912add66ac

❌ pre-commit FAILURE in 39s
❌ ogr-tests-rpm RETRY_LIMIT in 44s
❌ ogr-tests-pip-deps RETRY_LIMIT in 37s
❌ ogr-reverse-dep-packit-tests FAILURE in 46s

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/4ce13b494a7c46afa1d7bee56a209501

✔️ pre-commit SUCCESS in 1m 39s
❌ ogr-tests-rpm FAILURE in 10m 33s
❌ ogr-tests-pip-deps FAILURE in 10m 49s
✔️ ogr-reverse-dep-packit-tests SUCCESS in 14m 34s

@lbarcziova
Copy link
Member Author

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/9076304206264bbc81eed7b48d930974

✔️ pre-commit SUCCESS in 1m 45s
❌ ogr-tests-rpm FAILURE in 10m 23s
❌ ogr-tests-pip-deps FAILURE in 10m 24s
✔️ ogr-reverse-dep-packit-tests SUCCESS in 14m 53s

TomasTomecek and others added 4 commits December 18, 2024 07:52
@TomasTomecek @lbarcziova
verify RPMs using rpminspect
f575b54 
Signed-off-by: Tomas Tomecek <[email protected]>
@lbarcziova
rpminspect tests: exclude metadata check, check distro
0244252
@lbarcziova
Rename rpminspect plans
864cb13
@lbarcziova
Run rpminspect on the SRPM rebuilt by Copr
e1adbeb 
TF downloads both RPMs and SRPM (rebuilt by Copr), so we can run rpminspect on all of them in one step.
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/73856f30f96b45bdaf7ad8df922a0973

✔️ pre-commit SUCCESS in 2m 40s
✔️ ogr-tests-pip-deps SUCCESS in 17m 03s

@LecrisUT
Copy link

Actually things have evolved a bit here. How about using the packit/tmt-plans repo? https://github.com/packit/tmt-plans/tree/main/plans/rpminspect. Iirc there was an issue with rpminspect on rawhide related to rpminspect itself, but if the current ones are working fine, maybe it is resolved. Alternatively we could work on https://github.com/fedora-ci/rpminspect-pipeline to make it copr compatible, the benefit being that in that case it's the same container that is used in Fedora-CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LecrisUT LecrisUT LecrisUT left review comments

@lachmanfrantisek lachmanfrantisek lachmanfrantisek left review comments

@jpopelka jpopelka jpopelka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lbarcziova @mfocko @LecrisUT @jpopelka @lachmanfrantisek @TomasTomecek