Feat/valkey support #597
Feat/valkey support #597
Conversation
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 39s |
mfocko
force-pushed
the
feat/valkey-support
branch
from
6d6d60a
to
4d0d159
Compare
|
Build succeeded. ✔️ pre-commit SUCCESS in 2m 02s |
mfocko
force-pushed
the
feat/valkey-support
branch
from
4d0d159
to
713d64c
Compare
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 41s |
mfocko
force-pushed
the
feat/valkey-support
branch
from
713d64c
to
f153287
Compare
|
Build failed. ❌ pre-commit NODE_FAILURE Node request 200-0007605115 failed in 0s |
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 38s |
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 59s |
1. Rely on a single tag ‹with_kv_database› for deciding whether it
should be deployed or not.
2. Introduce a new variable ‹kv_database› that holds the name of the KV
database that might be deployed.
- Also allows for easier deduction of the hostname and makes sure
that there's always at least one deployment of any kind, i.e., it
is now not possible to require it present, but have incorrect
combination of flags, e.g., neither ‹with_redis› nor ‹with_redict›
set.
3. Add it to templates where it's been forgotten.
Signed-off-by: Matej Focko <[email protected]>
Signed-off-by: Matej Focko <[email protected]>
The leaks in short-running pods result in idle connections to Redict/Valkey, all of these KV-databases have ‹timeout› option in their config that allows for iterative cleanup of hanging connections. This mitigates the issue to the point of still having free connections slots to Redict/Valkey, i.e., the pods shall be killed, but handlers do not end up in a retry-loop trying to connect to Redict/Valkey. Since the config is 1:1 between all Redis, Redict, and Valkey, create one ConfigMap, map the config into the databases and pass the path to the config as an argument. Tested with Redict and Valkey. »NOT« tested with Redis. Related to packit/packit-service#2522 Signed-off-by: Matej Focko <[email protected]>
mfocko
force-pushed
the
feat/valkey-support
branch
from
c000b31
to
64cdcec
Compare
|
Build succeeded. ✔️ pre-commit SUCCESS in 2m 00s |
| redis: "{{ with_redis }}" | ||
| redict: "{{ with_redict }}" | ||
| redis: "{{ with_kv_database and kv_database == 'redis' }}" | ||
| redict: "{{ with_kv_database and kv_database == 'redict' }}" |
There was a problem hiding this comment.
| redict: "{{ with_kv_database and kv_database == 'redict' }}" | |
| redict: "{{ with_kv_database and kv_database == 'redict' }}" | |
| valkey: "{{ with_kv_database and kv_database == 'valkey' }}" |
Not sure why we need this facts but isn't valkey missing here?
There was a problem hiding this comment.
Oh, right, must've missed it.
This builds up the optional_deploymentconfigs, from that we build the deploymentconfigs and finally it's checked here
deployment/playbooks/deploy.yml
Lines 440 to 446 in 2892b42
that they're running. It's a bit flaky though, cause it doesn't work properly if you don't run oc project ‹packit namespace› beforehand in the terminal.
mfocko
force-pushed
the
feat/valkey-support
branch
from
0dc44f5
to
9bb28fb
Compare
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 42s |
- Remove tags for redis and redict, they would not be very helpful, since the specific implementation of KV-DB is taken from the variables anyways - Add missing Valkey to the deploymentconfigs - Add comment with options to the deployment templates Co-authored-by: Maja Massarini <[email protected]> Signed-off-by: Matej Focko <[email protected]>
mfocko
force-pushed
the
feat/valkey-support
branch
from
9bb28fb
to
660a23a
Compare
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 39s |
Related to packit/packit-service#2522