-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add script to provide team velocity #404
base: main
Are you sure you want to change the base?
Add script to provide team velocity #404
Conversation
by calculating the weekly numbers of closed issues. Signed-off-by: Frantisek Lachman <[email protected]>
086df5d
to
2890b7b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
neat!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, nicely done! Do you plan to add some README
e.g. also mentioning what would be the values for the labels that we will use? (I was also a little bit surprised by the location of the script)
issue_labels = [label.name for label in issue.labels] | ||
value: Optional[int] = None | ||
for label_name, label_value in labels: | ||
if label_name in issue_labels: | ||
value = label_value | ||
|
||
if value is not None: | ||
return value |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so this should work as Later definition has priority
right? Maybe it would also make sense to always get the max value?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so this should work as Later definition has priority right?
Yes, but max
might be a better idea.
return week_numbers | ||
|
||
|
||
DEFAULT_PROJECTS = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am wondering if we could make this dynamically evaluated as well..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking about that but we don't have this in OGR and not easily via pygithub as well... I'd leave this for later.
I would wait for a while to agree on "our" definition and will add it there. I agree it does not fit into this repo completely but better than elsewhere..;) |
by calculating the weekly numbers of closed issues.