Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add script to provide team velocity #404

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lachmanfrantisek
Copy link
Member

by calculating the weekly numbers of closed issues.

image

by calculating the weekly numbers of closed issues.

Signed-off-by: Frantisek Lachman <[email protected]>
Copy link
Member

@TomasTomecek TomasTomecek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neat!

get_velocity.py Show resolved Hide resolved
Copy link
Member

@lbarcziova lbarcziova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, nicely done! Do you plan to add some README e.g. also mentioning what would be the values for the labels that we will use? (I was also a little bit surprised by the location of the script)

Comment on lines +56 to +63
issue_labels = [label.name for label in issue.labels]
value: Optional[int] = None
for label_name, label_value in labels:
if label_name in issue_labels:
value = label_value

if value is not None:
return value
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so this should work as Later definition has priority right? Maybe it would also make sense to always get the max value?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so this should work as Later definition has priority right?

Yes, but max might be a better idea.

return week_numbers


DEFAULT_PROJECTS = [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am wondering if we could make this dynamically evaluated as well..

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking about that but we don't have this in OGR and not easily via pygithub as well... I'd leave this for later.

@lachmanfrantisek
Copy link
Member Author

thanks, nicely done! Do you plan to add some README e.g. also mentioning what would be the values for the labels that we will use? (I was also a little bit surprised by the location of the script)

I would wait for a while to agree on "our" definition and will add it there. I agree it does not fit into this repo completely but better than elsewhere..;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants