Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Refactor actions project as NodeJS #10

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

LecrisUT
Copy link

@LecrisUT LecrisUT commented Jul 6, 2023

I have been considering whether to use composite or TS/JS based action. I am not sure which one would be better, but maybe it can be mixed-and-matched

Comparison

Composite:

Pro

  • Can easily call any actions
  • More familiar structure

Con

  • Cannot mock or have complex testing framework
  • Web API can get complicated
  • Debugging can get messy when nesting actions

Proposal

  • Use as a wrapper for multiple actions

NodeJS:

Pro

  • More flexible in reporting, try/catch, etc.
  • Can pull non GH Action packages
  • Full testing suite capabilities
  • Cleaner structure

Con

  • More complicated to call other actions. Can't find documentation if it is possible in actions/toolkit
  • Requires setting up an environment to compile the actions

Proposal

  • Use for core action interface

Basically I believe we can achieve the same functionality with either framework, but this one provides better testing capabilities. One major con for JS framework is the complexity for calling other actions. Maybe we could call other JS actions, but I need to experiment more on how to do that.

Signed-off-by: Cristian Le <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant