Handle "self.version" constraints

package-health · May 9, 2023 · f94e94c · f94e94c
1 parent cfcdc80
commit f94e94c
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 7 deletions.
diff --git a/src/Application/Processor/Handler/CheckDependencyStatusHandler.php b/src/Application/Processor/Handler/CheckDependencyStatusHandler.php
@@ -111,7 +111,7 @@ public function __invoke(CommandInterface $command, array $attributes = []): Han
       );
 
       if ($dependency->getConstraint() === 'self.version') {
-        // need to find out how to handle this
+        // should never happen as PackageDiscovery sets it to release version, but just in case
         return HandlerResultEnum::REJECT;
       }
 

diff --git a/src/Application/Processor/Handler/PackageDiscoveryHandler.php b/src/Application/Processor/Handler/PackageDiscoveryHandler.php
@@ -286,8 +286,7 @@ static function (Version $version): string {
 
           foreach ($filteredRequire as $dependencyName => $constraint) {
             if ($constraint === 'self.version') {
-              // need to find out how to handle this
-              continue;
+              $constraint = $release['version'];
             }
 
             // find by the unique constraint (version_id, name, development)
@@ -332,8 +331,7 @@ static function (Version $version): string {
 
           foreach ($filteredRequireDev as $dependencyName => $constraint) {
             if ($constraint === 'self.version') {
-              // need to find out how to handle this
-              continue;
+              $constraint = $release['version'];
             }
 
             // find by the unique constraint (version_id, name, development)

diff --git a/src/Application/Processor/Handler/UpdateDependencyStatusHandler.php b/src/Application/Processor/Handler/UpdateDependencyStatusHandler.php
@@ -118,7 +118,7 @@ public function __invoke(CommandInterface $command, array $attributes = []): Han
 
       foreach ($dependencyCol as $dependency) {
         if ($dependency->getConstraint() === 'self.version') {
-          // need to find out how to handle this
+          // should never happen as PackageDiscovery sets it to release version, but just in case
           continue;
         }
 
@@ -130,7 +130,7 @@ public function __invoke(CommandInterface $command, array $attributes = []): Han
 
         foreach ($dependencyCol as $dependency) {
           if ($dependency->getConstraint() === 'self.version') {
-            // need to find out how to handle this
+            // should never happen as PackageDiscovery sets it to release version, but just in case
             continue;
           }