Remove unused listeners

package-health · Mar 16, 2022 · 45ff74d · 45ff74d
1 parent f6edbd1
commit 45ff74d
Show file tree

Hide file tree

Showing 13 changed files with 22 additions and 113 deletions.
diff --git a/app/messages.php b/app/messages.php
@@ -4,33 +4,26 @@
 use App\Application\Message\Command\PackageDiscoveryCommand;
 use App\Application\Message\Command\UpdateDependencyStatusCommand;
 use App\Application\Message\Command\UpdateVersionStatusCommand;
-use App\Application\Message\Event\Dependency\DependencyCreatedEvent;
 use App\Application\Message\Event\Dependency\DependencyUpdatedEvent;
 use App\Application\Message\Event\Package\PackageCreatedEvent;
 use App\Application\Message\Event\Package\PackageUpdatedEvent;
 use App\Application\Message\Event\Version\VersionCreatedEvent;
-use App\Application\Message\Event\Version\VersionUpdatedEvent;
 use App\Application\Processor\Handler\PackageDiscoveryHandler;
 use App\Application\Processor\Handler\UpdateDependencyStatusHandler;
 use App\Application\Processor\Handler\UpdateVersionStatusHandler;
-use App\Application\Processor\Listener\Dependency\DependencyCreatedListener;
 use App\Application\Processor\Listener\Dependency\DependencyUpdatedListener;
 use App\Application\Processor\Listener\Package\PackageCreatedListener;
 use App\Application\Processor\Listener\Package\PackageUpdatedListener;
 use App\Application\Processor\Listener\Version\VersionCreatedListener;
-use App\Application\Processor\Listener\Version\VersionUpdatedListener;
 use Courier\Bus;
 use Psr\Container\ContainerInterface;
 
 return static function (ContainerInterface $container): void {
-  $router = $container->get(Bus::class)->getRouter();
+  $bus    = $container->get(Bus::class);
+  $router = $bus->getRouter();
 
   /* DEPENDENCY EVENTS */
   $router
-    ->addRoute(
-      DependencyCreatedEvent::class,
-      DependencyCreatedListener::class
-    )
     ->addRoute(
       DependencyUpdatedEvent::class,
       DependencyUpdatedListener::class
@@ -52,10 +45,6 @@
     ->addRoute(
       VersionCreatedEvent::class,
       VersionCreatedListener::class
-    )
-    ->addRoute(
-      VersionUpdatedEvent::class,
-      VersionUpdatedListener::class
     );
 
   /* PACKAGE COMMANDS */
@@ -75,4 +64,6 @@
     UpdateVersionStatusCommand::class,
     UpdateVersionStatusHandler::class
   );
+
+  $bus->bindRoutes();
 };
diff --git a/app/processors.php b/app/processors.php
@@ -4,12 +4,10 @@
 use App\Application\Processor\Handler\PackageDiscoveryHandler;
 use App\Application\Processor\Handler\UpdateDependencyStatusHandler;
 use App\Application\Processor\Handler\UpdateVersionStatusHandler;
-use App\Application\Processor\Listener\Dependency\DependencyCreatedListener;
 use App\Application\Processor\Listener\Dependency\DependencyUpdatedListener;
 use App\Application\Processor\Listener\Package\PackageCreatedListener;
 use App\Application\Processor\Listener\Package\PackageUpdatedListener;
 use App\Application\Processor\Listener\Version\VersionCreatedListener;
-use App\Application\Processor\Listener\Version\VersionUpdatedListener;
 use DI\ContainerBuilder;
 use function DI\autowire;
 
@@ -26,12 +24,10 @@
   /* LISTENERS */
   $containerBuilder->addDefinitions(
     [
-      DependencyCreatedListener::class => autowire(DependencyCreatedListener::class),
       DependencyUpdatedListener::class => autowire(DependencyUpdatedListener::class),
       PackageCreatedListener::class    => autowire(PackageCreatedListener::class),
       PackageUpdatedListener::class    => autowire(PackageUpdatedListener::class),
       VersionCreatedListener::class    => autowire(VersionCreatedListener::class),
-      VersionUpdatedListener::class    => autowire(VersionUpdatedListener::class)
     ]
   );
 };
diff --git a/composer.json b/composer.json
@@ -53,13 +53,13 @@
   },
   "require-dev": {
     "infection/infection": "^0.26",
-    "php-parallel-lint/php-parallel-lint": "^1.2",
+    "php-parallel-lint/php-parallel-lint": "^1.3",
     "phpstan/phpstan": "^1.4",
     "phpunit/phpunit": "^9.5",
     "psy/psysh": "^0.11",
     "roave/security-advisories": "dev-latest",
-    "squizlabs/php_codesniffer": "^3.5",
-    "vimeo/psalm": "^4.3"
+    "squizlabs/php_codesniffer": "^3.6",
+    "vimeo/psalm": "^4.8"
   },
   "scripts": {
     "console": "vendor/bin/psysh",

diff --git a/composer.lock b/composer.lock
diff --git a/src/Application/Console/Packagist/GetDataCommand.php b/src/Application/Console/Packagist/GetDataCommand.php
@@ -133,8 +133,6 @@ protected function execute(InputInterface $input, OutputInterface $output): int
 
       $json = json_decode(file_get_contents($dataPath), true, 512, JSON_THROW_ON_ERROR);
 
-      $this->producer->setupBroker();
-
       $package = $this->packageRepository->get($packageName);
       $package = $package
         ->withDescription($json['package']['description'] ?? '')

diff --git a/src/Application/Console/Packagist/GetListCommand.php b/src/Application/Console/Packagist/GetListCommand.php
@@ -149,8 +149,6 @@ static function (Package $package): string {
         )
       );
 
-      $this->producer->setupBroker();
-
       foreach ($addList as $packageName) {
         $package = $this->packageRepository->create($packageName);
 

diff --git a/src/Application/Console/Queue/QueueConsumerCommand.php b/src/Application/Console/Queue/QueueConsumerCommand.php
@@ -48,8 +48,6 @@ protected function execute(InputInterface $input, OutputInterface $output): int
         )
       );
 
-      $this->consumer->setupBroker();
-
       while (true) {
         $this->consumer->consume();
         usleep(200000);

diff --git a/src/Application/Processor/Listener/Dependency/DependencyCreatedListener.php b/src/Application/Processor/Listener/Dependency/DependencyCreatedListener.php
diff --git a/src/Application/Processor/Listener/Dependency/DependencyUpdatedListener.php b/src/Application/Processor/Listener/Dependency/DependencyUpdatedListener.php
@@ -23,7 +23,7 @@ public function __construct(Producer $producer, LoggerInterface $logger) {
    */
   public function __invoke(EventInterface $event): void {
     $dependency = $event->getDependency();
-    $this->logger->debug('Dependency updated', [$dependency]);
+    // $this->logger->debug('Dependency updated', [$dependency]);
 
     $this->producer->sendCommand(
       new UpdateVersionStatusCommand($dependency)

diff --git a/src/Application/Processor/Listener/Package/PackageCreatedListener.php b/src/Application/Processor/Listener/Package/PackageCreatedListener.php
@@ -21,7 +21,7 @@ public function __construct(Producer $producer, LoggerInterface $logger) {
 
   public function __invoke(EventInterface $event): void {
     $package = $event->getPackage();
-    $this->logger->debug('Package created', [$package]);
+    // $this->logger->debug('Package created', [$package]);
 
     $this->producer->sendCommand(
       new PackageDiscoveryCommand($package)

diff --git a/src/Application/Processor/Listener/Package/PackageUpdatedListener.php b/src/Application/Processor/Listener/Package/PackageUpdatedListener.php
@@ -22,7 +22,7 @@ public function __construct(Producer $producer, LoggerInterface $logger) {
 
   public function __invoke(EventInterface $event): void {
     $package = $event->getPackage();
-    $this->logger->debug('Package updated', [$package]);
+    // $this->logger->debug('Package updated', [$package]);
 
     if ($package->getLatestVersion() === '') {
       return;

diff --git a/src/Application/Processor/Listener/Version/VersionCreatedListener.php b/src/Application/Processor/Listener/Version/VersionCreatedListener.php
@@ -37,7 +37,7 @@ public function __construct(
    */
   public function __invoke(EventInterface $event): void {
     $version = $event->getVersion();
-    $this->logger->debug('Version created', [$version]);
+    // $this->logger->debug('Version created', [$version]);
 
     // ignore non-release versions
     if ($version->isRelease() === false) {

diff --git a/src/Application/Processor/Listener/Version/VersionUpdatedListener.php b/src/Application/Processor/Listener/Version/VersionUpdatedListener.php