Adds validation state feedback to nodes #475
Open
+195
−43
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is to have a
NodeValidationState
member object in theNodeDelegateModel
class, that defaults to a valid and empty state message. The API allows for updates to be made accordingly, and the UI will respond automatically.UI will show a node red (error) or yellow (warning). A tooltip is added with the state message. And a small icon for information is displayed as a badge, to help the user access the tooltip. I added a screenshot of the calculator example to help discussions. in the example, the tooltip for the Warning state is displayed.
Key Changes
NodeValidationState
struct class.DataFlowGraphModel
handlesNodeRole::ValidationState
updates.DefaultNodePainter
.NodeGraphicsObject
.Solves #226
Solves #75
P.S.: some changes happened automatically when saving files, due to autoformatting using nodeeditor clang format style.