Use cs2pr; remove composer-patches dependency #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's another way to get PHPCS annotations on PRs, by using cs2pr. The use of composer-patches isn't great. I didn't know at the time, but all packages that require this package attempt to apply the patches specified here. Not ideal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main way to get PHPCS annotations on PRs is by using cs2pr.
The use of composer-patches isn't great. I didn't know at the time of my earlier PR, but all packages that require this package (wp-namespace-autoloader) attempt to apply the patches specified here. Not ideal.
cs2pr actually references work I did on the report type approach, which is nice! I don't understand why phpcs haven't merged the PR that was being applied here by composer-patches.
*to^3.6(current)