Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include runner configuration per task and include global configuration #144

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sudheesh001
Copy link
Contributor

  • Initial attempt at including runner configurations into pa11y-webservices
  • This patch include per-task runner configuration with the POST /tasks request including the runners: [] entries
  • This patch allows edits of the runner configuration with the PATCH requests with the runners: [] entries.
  • The global service can be configured with the runners: [] in config/ as the default.

Firstly thank you to the pa11y community for such an amazing project. In this PR, I am requesting feedback in the attempt of addressing #88. It has been a long time since #127 was proposed and it hasn't had any recent updates on it. I apologize in advance if this might be overstepping on the work done in the previous patch. Enabling this setting was needed and helpful for a project I've been doing recently and I would like to get feedback from the community on if this design is preferable. This would definitely result in changes in the pa11y-dashboard. It'd also be interesting to see if pa11y can expose a pa11y.availableRunners() of some sort.

Signed-off-by: Sudheesh Singanamalla [email protected]

@danyalaytekin
Copy link
Member

danyalaytekin commented Mar 17, 2024

Hi @sudheesh001, thanks for this contribution way back in 2022! It looks good at first glance to me. I've assigned it to the 5.x milestone for now, and will return to think about this some more once pa11y-webservice@5 has been released.

@danyalaytekin danyalaytekin added this to the 5.x milestone Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants