Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release pa11y-webservice-client-node@4 #24

Merged
merged 5 commits into from
Mar 26, 2024
Merged

Release pa11y-webservice-client-node@4 #24

merged 5 commits into from
Mar 26, 2024

Conversation

danyalaytekin
Copy link
Member

@danyalaytekin danyalaytekin commented Mar 18, 2024 •
edited
Loading

Note

  1. pa11y-bot will release [email protected] from main once this is merged and the draft GitHub Release published
  2. Full diff since 3.0.0

Components

Changes in this PR

  • Add custom badge to show pa11y-webservice API support 8bb5333
  • Update package*.json
  • Add CHANGELOG.md file and an entry for 4.0.0
  • Add MIGRATION.md entry
  • Update README.md
  • Create draft release

@danyalaytekin danyalaytekin added the status: work required Work in progress label Mar 18, 2024
@danyalaytekin danyalaytekin added this to the 4.0.0 milestone Mar 18, 2024
@danyalaytekin danyalaytekin self-assigned this Mar 18, 2024
@danyalaytekin danyalaytekin mentioned this pull request Mar 20, 2024
Open
6 tasks
@danyalaytekin danyalaytekin marked this pull request as ready for review March 21, 2024 23:23
@danyalaytekin danyalaytekin changed the title [Awaiting components] Release pa11y-webservice-client-node@4 Release pa11y-webservice-client-node@4 Mar 21, 2024
@danyalaytekin danyalaytekin removed the status: work required Work in progress label Mar 21, 2024
@danyalaytekin danyalaytekin mentioned this pull request Mar 21, 2024
Open
19 tasks
sangitamane
sangitamane approved these changes Mar 22, 2024
View reviewed changes
Copy link
Member

@sangitamane sangitamane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@danyalaytekin
Copy link
Member Author

Thanks @sangitamane. Will leave this in review over the weekend and we can release on Monday if all is well.

@danyalaytekin danyalaytekin merged commit 6836666 into main Mar 26, 2024
5 checks passed
@danyalaytekin danyalaytekin deleted the version-4 branch March 26, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sangitamane sangitamane sangitamane approved these changes

@hollsk hollsk Awaiting requested review from hollsk

@josebolos josebolos Awaiting requested review from josebolos

Assignees

@danyalaytekin danyalaytekin

Labels
None yet
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@danyalaytekin @sangitamane