-
Notifications
You must be signed in to change notification settings - Fork 476
Implement basic toString method for ebpf types. #5371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Unfortunately I still see the same error with this patch: |
Can not reproduce this... which compiler are you using? Might also be caused by a different boost version |
ad7149c to
21da60b
Compare
|
I'm using I just did a clean build again to make sure it's not caused by the build cache, but I'm still able to reproduce this issue with the patch. |
5e75b98 to
6f4d221
Compare
Signed-off-by: fruffy <[email protected]>
6f4d221 to
e807026
Compare
|
|
||
| /// Base class for EBPF objects. | ||
| class EBPFObject : public ICastable { | ||
| class EBPFObject : virtual public ICastable, public IHasDbPrint { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IHasDbPrint should be a virtual base class as well, though that probably doesn't affect this issue, as there are no other inhertances of it from any subclass
Hopefully fixes #5370.
@jkhsjdhjs Can you give this a try?
The right way to solve this is to add
virtual cstring node_type_name() const = 0;to the ICastable class and invoke it in thecheckedTocall. But this might be a breaking change...