Add cplint workflow support for minimal lint-only builds #5225
Conversation
blackdragoon26
force-pushed
the
troubleshootingLint
branch
from
06d04b7 to
54a7cc7
Compare
|
As you can see, the step fails. This problem is about minimizing the requirements for running |
fruffy
added
the
infrastructure
|
Alright, will dig into CMakefile.txt and I suspect for issue of incomplete if (NOT Linting) Conditions. Btw, I ran make command which started the actual build, and my whole Laptop crashed(was working in docker env then). |
|
No, this is not expected behavior but it is possible that you run out of memory if your system does not have a lot of RAM. |
|
hey @blackdragoon26! I found out that , you are doing amazing work, I was reading the logs of failed check, it was due to the outdated version setup tools, you should modify the ci workflow with this command -pip install --upgrade setuptools |
|
Thanks alot, I would look into it @AkarshSahlot |
blackdragoon26
force-pushed
the
troubleshootingLint
branch
3 times, most recently
from
1740f0b to
2bb9a9b
Compare
|
@fruffy , kindly review it! |
CMakeLists.txt
Outdated
| @@ -24,6 +24,58 @@ endif() | |||
|
|
|||
| project (P4C) | |||
|
|
|||
| # Minimal lint-only configuration | |||
| if (CMAKE_LINT_ONLY) | |||
There was a problem hiding this comment.
This isn't really what I have been looking for. This just copies what is already there in the Linters file but without all the options.
You should be able to pass linting with with cmake .. -DCMAKE_LINT_ONLY and also use the functions present in
https://github.com/p4lang/p4c/blob/main/cmake/Linters.cmake.
There was a problem hiding this comment.
This would mean you should make the changes in the back ends and around the checks that fail in CMake.
There was a problem hiding this comment.
Got it,
I will rework on it.
blackdragoon26
force-pushed
the
troubleshootingLint
branch
from
3d56868 to
614dbfa
Compare
Signed-off-by: blackdragoon26 <[email protected]>
blackdragoon26
force-pushed
the
troubleshootingLint
branch
from
26645df to
0bcc0fc
Compare
Working on this issue #4534
I made the tweaks in the lint workflow so that we can run cpplint without needing to build everything.
I ran these following commands
mkdir -p build && cd buildcmake .. -DCMAKE_LINT_ONLY=ONcmake --build . --target cpplintI am thinking as next step to further dig in to check for running once isolated docker env.