Update googletest code in third_party #1238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoninbas
reviewed
Apr 5, 2024
There was a problem hiding this comment.
https://github.com/google/googletest/releases/tag/v1.14.0 mentions that GoogleTest requires at least C++14. This project only requires C++11 and builds with -std=c+11. While it seems that CI tests are passing fine, IMO we should still follow one of these 2 approaches:
- Update to v1.12.1 instead, as it is the last version to support C++11, but should still be much more recent than what we have today
- Update this project (bmv2) to require C++14. Obviously, this is more involved than approach 1. It would require updating documentation, build scripts, and before making that change, we shoudl probably cut one last bmv2 release with "C++11 support".
I chose this method because I am newbie in open source. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update googletest code to v1.12.1 version from here.