fix for issue #136 : tags counting #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -417,10 +417,15 @@ def get_non_started_next_projects(self, user): | |||
| return Project.objects.none() | |||
|
|
|||
| @classmethod | |||
| def get_projects_excluded_from_listing(cls): | |||
There was a problem hiding this comment.
Just a thought, but wouldn't it make more sense to return the listed projects? The queries in get_popular_tags and get_weighted_tags can also be changed to use the listed projects instead.
Also, consider returning the QuerySet rather than a list of ids
There was a problem hiding this comment.
Heya, it does make sense; actuallay I was stuck for a while till I figured out that it was a dict of ids. It makes the test harder to write, which in itself is a sign that something is wrong. :)
I won't have time to look at this for now, so feel free to apply it and we can revisit later, or to make the changes yourself, or I will make them probably at the weekend.
|
Cool, I'll merge and make the changes! |
dirkcuys
added a commit
that referenced
this pull request
Jun 25, 2012
fix for issue #136 : tags counting
dirkcuys
added a commit
that referenced
this pull request
Aug 31, 2012
fix for issue #136 : tags counting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Dirk,
Please have a look at the commit; it adds a test and some refactoring; It actually fixes the counting problem #136 but there is an issue with filtering out all groups but Challenges in the view (discussed in mailing list). Will add a separate bug for that (not sure I have permissions) and a different pull request (I have it tracked down but want to create a test to reproduce it; although as you mentioned, testing the views is a lot messier, so will take a bit).
cheers!