Config ulong packing #490
Open
Config ulong packing #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
assumptions on values being uint64_t elsewhere in the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds configurable packing and CK_ULONG to the project, along with printf format specifiers for code. It does not fix other issues when used with --with-pkcs11-longtype=32. If this is of value to this project, I will fix the rest of the code to run on 32 bit CK_ULONGs. The default config leaves the code with long int/ unsigned long it.
Best I can tell, most of it involves printf formatting, but it's a bit of work if this is not of interest.