Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: corrects the writing of media requests #53

Merged
merged 2 commits into from
May 4, 2024

Conversation

wwily
Copy link
Contributor

@wwily wwily commented Apr 24, 2024

Description

This pull request resolves #40

Changes Made

I ensured uniform usage and formatting of media queries throughout the project.

From this:

@media (max-width:1199px){
...
}

@media (max-width:659px){
...
}

To this:

@media screen and (max-width: 1199px){
...
}

@media screen and (max-width: 659px){
...
}

@naumch1k
Copy link
Member

naumch1k commented Apr 26, 2024

Hey, @NazarPauk @MarPostovik 👋 Do you guys have any formatting rules for media requests? Most of them have a space between max-width: and the value, but the ones in this PR don't.

@media screen and (max-width: 659px) {}
/* vs */
@media screen and (max-width:659px) {}

@MarPostovik
Copy link
Contributor

@naumch1k Thank you for noticing this. I think we should stick to the first option (with the space).
@wwily Would you kindly add the spaces to the media queries that don't have them?

@wwily
Copy link
Contributor Author

wwily commented May 2, 2024

I made changes:)

@naumch1k naumch1k self-requested a review May 4, 2024 17:44
Copy link
Member

@naumch1k naumch1k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wwily Thank you for taking the time to ensure consistent formatting in our project's media queries. Your PR has been approved!

@naumch1k naumch1k merged commit dfe9928 into main May 4, 2024
@naumch1k naumch1k deleted the refactor-media-queries branch May 4, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor: Using two types of media queries
3 participants