Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Form Fieldset UI component #21

Merged
merged 26 commits into from
Apr 24, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
be22264
feat: add html structure
rasokolovska Mar 6, 2024
ddad635
feat: add css structure
rasokolovska Mar 6, 2024
d41e35f
feat: add styles for the fieldset.css file
rasokolovska Mar 6, 2024
b84fc1e
feat: add styles for the fieldset__title.css file
rasokolovska Mar 6, 2024
c25b60b
feat:imported styles into components.css
rasokolovska Mar 6, 2024
345c8fe
fix:changed the html structure, names of classes and modifiers
rasokolovska Mar 12, 2024
4b4d8a2
feat: add styles for the form-fieldset__legend.css file
rasokolovska Mar 12, 2024
b8b18d5
feat: add styles for the form-fieldset.css file
rasokolovska Mar 12, 2024
96b6643
feat: add styles for form-fieldset__legend_for_impressions and form-f…
rasokolovska Mar 12, 2024
37fbb72
feat: add styles for form-fieldset__legend_for_achievements and form-…
rasokolovska Mar 12, 2024
37da654
feat: add styles for form-fieldset__legend_for_contact-info and form-…
rasokolovska Mar 12, 2024
b83f300
feat: add styles for form-fieldset_for_app-type and form-fieldset__le…
rasokolovska Mar 12, 2024
c784d5e
feat: added description to the element
rasokolovska Mar 12, 2024
e06c952
fix:set the margin of the form-fieldset element to zero
rasokolovska Mar 12, 2024
b0bd4c4
fix:added centering to the form-fieldset__legend element
rasokolovska Mar 12, 2024
a487e4a
fix: changed legend positioning for desktop version
rasokolovska Mar 20, 2024
de14a90
fix: fixed legend behavior on phone versions on the _for_app-type mod…
rasokolovska Apr 5, 2024
e73d7bd
fix: added absolute positioning to the _achievements and _app-type mo…
rasokolovska Apr 9, 2024
21acb5b
fix: indentation in modifiers for the fieldset element
rasokolovska Apr 15, 2024
fc2d97b
fix: corrected errors
rasokolovska Apr 23, 2024
d140ce0
fix: reverts changes to index.html
naumch1k Apr 24, 2024
8b753d7
style: ensures CSS formatting follows project code style
naumch1k Apr 24, 2024
a6cae23
fix: removes extra closing div tag, ensures proper indentation in com…
naumch1k Apr 24, 2024
896fbb9
docs: improves Form Fieldset UI Component description
naumch1k Apr 24, 2024
c841f99
style: updates components.css for formatting consistency, ensures vis…
naumch1k Apr 24, 2024
d4b77e8
Merge branch 'main' into feature-fieldset
naumch1k Apr 24, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,3 +1,23 @@
.form-fieldset__legend_for_achievements{
padding:14px 31px;
padding: 0 25px;
background-color:rgb(255, 255, 255);
position: absolute;
top: -9px;
left: 50%;
transform: translateX(-50%);
}
/* @media screen and (max-width: 1199px) {
.form-fieldset__legend_for_achievements{
padding: 0;
width: 370px;
}
} */
@media screen and (max-width: 659px) {
.form-fieldset__legend_for_achievements{
width: 100%;
position: static;
transform: none;
padding:42px 0 40px;
background-color:rgba(242, 242, 242, 1);
}
}
Original file line number Diff line number Diff line change
@@ -1,9 +1,23 @@
.form-fieldset__legend_for_app-type{
width: 370px;
padding: 0;
position: absolute;
padding: 0 25px;
background-color:rgb(255, 255, 255);
position: absolute;
top: -9px;
left: 50%;
transform: translateX(-50%);
}
@media screen and (max-width: 1199px) {
.form-fieldset__legend_for_app-type{
padding: 0;
width: 370px;
}
}
@media screen and (max-width: 659px) {
.form-fieldset__legend_for_app-type{
width: 100%;
position: static;
transform: none;
padding:42px 0 40px;
background-color:rgba(242, 242, 242, 1);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -9,5 +9,6 @@
@media (max-width:659px){
.form-fieldset_for_achievements{
padding:0;
background-color:rgba(242, 242, 242, 1);
}
}
3 changes: 3 additions & 0 deletions blocks/form-fieldset/_for/form-fieldset_for_app-type.css
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
.form-fieldset_for_app-type{
padding: 54px 74px;
display: flex;
flex-wrap: wrap;
}
@media (max-width:1199px){
.form-fieldset_for_app-type{
Expand All @@ -9,5 +11,6 @@
@media (max-width:659px){
.form-fieldset_for_app-type{
padding: 0px;
background-color:rgba(242, 242, 242, 1);
}
}
5 changes: 5 additions & 0 deletions blocks/form-fieldset/_for/form-fieldset_for_personal-info.css
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
.form-fieldset_for_personal-info{
border: none;
padding: 0;
margin: 0;
}
1 change: 0 additions & 1 deletion blocks/form-fieldset/form-fieldset.css
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
.form-fieldset{
border: rgb(229, 229, 229) solid 2px;
naumch1k marked this conversation as resolved.
Show resolved Hide resolved
width: 100%;
box-sizing: border-box;
margin: 0;
Expand Down
8 changes: 5 additions & 3 deletions components.html
Original file line number Diff line number Diff line change
Expand Up @@ -129,11 +129,13 @@ <h2 class="component__name">Form-fieldset</h2>
<li><code>form-fieldset__legend_for_impressions</code></li>
<li><code>form-fieldset__legend_for_achievements</code></li>
</ul>
<div class="component__wrapper component__wrapper_theme_light">
<fieldset class="form-fieldset form-fieldset_for_app-type">
<legend class="form-fieldset__legend form-fieldset__legend_for_app-type">С каким приложением путешествовали?</legend>
<div class="component__wrapper ">
<fieldset class="form-fieldset form-fieldset_for_achievements">
<legend class="form-fieldset__legend form-fieldset__legend_for_achievements">Ваши безбашенные
достижения в путешествии</legend>
</fieldset>
</div>
</div>
</li>
</ul>
</section>
Expand Down
1 change: 1 addition & 0 deletions pages/components.css
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@
@import url(../blocks/form-fieldset/_for/form-fieldset_for_app-type.css);
@import url(../blocks/form-fieldset/_for/form-fieldset_for_achievements.css);
@import url(../blocks/form-fieldset/_for/form-fieldset_for_impressions.css);
@import url(../blocks/form-fieldset/_for/form-fieldset_for_personal-info.css);
/* legend */
@import url(../blocks/form-fieldset/__legend/form-fieldset__legend.css);
@import url(../blocks/form-fieldset/__legend/_for/form-fieldset__legend_for_app-type.css);
Expand Down