feat: add Form Fieldset UI component #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ieldset_for_impressions modifiers
…fieldset_for_achievements modifiers
…fieldset_for_contact-info modifiers
…gend_for_app-type modifiers
MarPostovik
reviewed
Apr 6, 2024
naumch1k
requested changes
Apr 23, 2024
There was a problem hiding this comment.
Hey @rasokolovska! 👋 Before we review your changes, could you resolve conflicts in the files mentioned below?
components.html
index.html
pages/components.css
|
@naumch1k So I have a question, is the solution to this problem to pull the update from the main branch? |
naumch1k
force-pushed
the
feature-fieldset
branch
2 times, most recently
from
0dae6e6
to
afe1424
Compare
naumch1k
force-pushed
the
feature-fieldset
branch
from
afe1424
to
d140ce0
Compare
…ually-hidden mix imports the last
naumch1k
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Form Fieldset serves as a container for grouping related form controls, providing a gray frame with a heading to structure and organize form elements. Legend element, identified by the
form-fieldset__legendclass, specifies the purpose of the grouped elements.Task Link
Figma Layout
Usage
Base class for the block is
form-fieldset. Along with the mandatory base class, it requires the corresponding modifier:form-fieldset_for_personal-infoform-fieldset_for_app-typeform-fieldset_for_contact-infoform-fieldset_for_achievementsform-fieldset_for_impressionsThe correct settings for the legend element demand the base class
form-fieldset__legendpaired with the corresponding modifier:form-fieldset__legend_for_app-typeform-fieldset__legend_for_contact-infoform-fieldset__legend_for_achievementsform-fieldset__legend_for_impressionsExample of Usage
Checklist
Before submitting this pull request, please ensure the following: