Add duration parameter #20
Conversation
ternimal.rs
Outdated
| @@ -251,6 +253,10 @@ fn main() { | |||
| // Hide cursor while printing canvas to avoid flickering | |||
| print!("\x1B[?25l{}\x1B[?25h\n", output); | |||
|
|
|||
| if duration >= 0.0 && time > duration { | |||
There was a problem hiding this comment.
This check probably belongs at the start of the rendering loop. Otherwise we are rendering another frame even though the elapsed time has already exceeded duration. Although in that case, we would exit the loop when the cursor is placed at the top of the canvas, which creates other problems... Not sure what the best solution is here.
I also don't think a duration of zero should be applied. If only a single frame is desired, this should be achieved using a separate frames parameter.
There was a problem hiding this comment.
Moved the check (and the cursor reset by necessity) to the beginning of the loop, only downside is this will cause a duration that's greater than 0 but very small to not draw any frames, which feels a bit wrong.
There was a problem hiding this comment.
I don't see an issue with this: If we have already spent more time than our budget, we need to exit. That part is exactly as it should be IMO.
What I don't like is that a duration of zero is accepted, which never makes sense. The default duration should be zero, meaning "run forever".
ternimal.rs
Outdated
| @@ -92,6 +92,8 @@ fn main() { | |||
| arg_var!(speed, 30.0, 0.0, 1000.0); | |||
| // Animation frames per second | |||
| arg_var!(fps, 30.0, 0.1, 600.0); | |||
| // Duration of model simlation in seconds (if this is less than 0, run forever) | |||
ccraciun
force-pushed
the
cos.params.duration
branch
from
d88f864 to
11b47b6
Compare
Not super happy with the name of the parameter, but let me know if this works or how to tweak it so it does.
Fixes #19