Skip to content

Conversation

eguguchkin
Copy link
Contributor

Fixes #150


  • I have read and followed all requirements in CONTRIBUTING.md;
  • I used LLM/AI assistance to make this pull request;

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 85.52632% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.18%. Comparing base (6ffb9f1) to head (d87cb5c).

Files with missing lines Patch % Lines
cmd/index_analyzer/main.go 0.00% 8 Missing ⚠️
fracmanager/cache_maintainer_metrics.go 93.33% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #175      +/-   ##
==========================================
- Coverage   71.22%   71.18%   -0.04%     
==========================================
  Files         198      199       +1     
  Lines       18210    18223      +13     
==========================================
+ Hits        12970    12972       +2     
- Misses       4522     4533      +11     
  Partials      718      718              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@eguguchkin eguguchkin added this to the v0.62.1 milestone Oct 3, 2025
@eguguchkin eguguchkin requested review from dkharms and moflotas October 3, 2025 14:28
@@ -0,0 +1,90 @@
package fracmanager
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So let's clarify this. We decided to follow this approach? Place metrics as near as possible to the place where they are used but in the separate file with name metrics.go?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Extract CacheMaintainerMetrics to a Separate File and Add Default Constructor

4 participants