Skip to content

Conversation

cheb0
Copy link
Member

@cheb0 cheb0 commented Sep 30, 2025

Description

Makes frac manager replay and seal fractions in parallel. This will speed up the process of store startup.

Fixes #161


  • I have read and followed all requirements in CONTRIBUTING.md;
  • I used LLM/AI assistance to make this pull request;

If you have used LLM/AI assistance please provide model name and full prompt:

Model: {{model-name}}
Prompt: {{prompt}}

@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2025

Codecov Report

❌ Patch coverage is 90.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.17%. Comparing base (3a431ab) to head (fba8263).
⚠️ Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
fracmanager/fracmanager.go 93.93% 2 Missing ⚠️
cmd/seq-db/seq-db.go 0.00% 1 Missing ⚠️
config/validation.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #169      +/-   ##
==========================================
- Coverage   71.21%   71.17%   -0.04%     
==========================================
  Files         198      199       +1     
  Lines       18219    18348     +129     
==========================================
+ Hits        12975    13060      +85     
- Misses       4521     4561      +40     
- Partials      723      727       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cheb0 cheb0 marked this pull request as ready for review October 1, 2025 13:45
@eguguchkin eguguchkin added this to the v0.62.1 milestone Oct 2, 2025
@eguguchkin eguguchkin removed this from the v0.62.1 milestone Oct 10, 2025
@eguguchkin eguguchkin added this to the v0.62.2 milestone Oct 10, 2025
})

assert.Error(t, err)
assert.Equal(t, err, context.DeadlineExceeded)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can use assert.ErrorIs() here too

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also removed previous assert assert.Error(t, err), since it looks unnecessary with two assert checks that comes later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Parallelize fractions seals on replay

5 participants