-
Notifications
You must be signed in to change notification settings - Fork 6
feat(fracmanager): parallelize seals on replay #169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #169 +/- ##
==========================================
- Coverage 71.21% 71.17% -0.04%
==========================================
Files 198 199 +1
Lines 18219 18348 +129
==========================================
+ Hits 12975 13060 +85
- Misses 4521 4561 +40
- Partials 723 727 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fracmanager/fracmanager_test.go
Outdated
}) | ||
|
||
assert.Error(t, err) | ||
assert.Equal(t, err, context.DeadlineExceeded) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can use assert.ErrorIs()
here too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also removed previous assert assert.Error(t, err)
, since it looks unnecessary with two assert checks that comes later
Description
Makes frac manager replay and seal fractions in parallel. This will speed up the process of store startup.
Fixes #161
If you have used LLM/AI assistance please provide model name and full prompt: