Skip to content

Conversation

moflotas
Copy link
Contributor

  • I have read and followed all requirements in CONTRIBUTING.md;
  • I used LLM/AI assistance to make this pull request;

If you have used LLM/AI assistance please provide model name and full prompt:

Model: {{model-name}}
Prompt: {{prompt}}

@eguguchkin eguguchkin modified the milestones: v0.61.2, v0.62.0, v0.62.1 Sep 26, 2025
// this doesn't block, and if store is down, it will try to reconnect in background
conn, err := grpc.DialContext(
ctx,
conn, err := grpc.NewClient(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a comment for DialContext method:

// One subtle difference between NewClient and Dial and DialContext is that the
// former uses "dns" as the default name resolver, while the latter use
// "passthrough" for backward compatibility.  This distinction should not matter
// to most users, but could matter to legacy users that specify a custom dialer
// and expect it to receive the target string directly.

I believe these is no difference for us, but could please you double-check it? (if you have not done this already, of course)

@moflotas moflotas force-pushed the 76-remove-old-parser branch from 3cd6eb3 to 89ffc71 Compare October 9, 2025 10:32
@moflotas moflotas force-pushed the 0-remove-unused-code branch from 6a77541 to 5b23696 Compare October 9, 2025 10:34
@eguguchkin eguguchkin modified the milestones: v0.62.1, v0.62.2 Oct 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants