Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Float rounds are adjusted & case sensitivity in eval metrics is removed #12

Merged
merged 3 commits into from
Dec 10, 2024

Conversation

ozguraslank
Copy link
Owner

Explanation

  • Rounding the float metrics changed from 4 to 6 #8e30c5a

  • Case sensitivity in eval metrics is removed. e.g. Typing 'RMSE' instead of 'rmse' or 'Accuracy' instead of 'accuracy' would raise error #8e30c5a

@ozguraslank ozguraslank added the enhancement New feature or request label Dec 7, 2024
@ozguraslank ozguraslank added this to the 1.1.0 milestone Dec 7, 2024
@ozguraslank ozguraslank self-assigned this Dec 7, 2024
* Since custom metrics are needed for model tuning processes, custom eval_metric_reveiser function is developed
* eval_metric_checker at SupervisedBase is moved to general validator module so that both model tuner and SupervisedBase can use it
@ozguraslank
Copy link
Owner Author

The reason of the last commit's fail is because of scikit-learn library's deprecated sklearn_tags attribute

tests/test_ml_models.py::TestMLModels::test_classification_ml_models_01_XGBClassifier
/opt/hostedtoolcache/Python/3.11.10/x64/lib/python3.11/site-packages/sklearn/utils/_tags.py:354: FutureWarning: The XGBClassifier or classes from which it inherits use _get_tags and _more_tags. Please define the __sklearn_tags__ method, or inherit from sklearn.base.BaseEstimator and/or other appropriate mixins such as sklearn.base.TransformerMixin, sklearn.base.ClassifierMixin, sklearn.base.RegressorMixin, and sklearn.base.OutlierMixin. From scikit-learn 1.7, not defining __sklearn_tags__ will raise an error.

Even though scikit-learn tells us this attribute will raise error starting from 1.7, It gives error in 1.6.

In order to resolve this problem for now, FlexML's scikit-learn version will be limited to <=1.5.2.

Related:

@ozguraslank ozguraslank merged commit a95dc34 into main Dec 10, 2024
4 checks passed
@ozguraslank ozguraslank deleted the module_structure_revise branch December 24, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant