Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve docs and add "Also see" section #5

Merged
merged 2 commits into from
Apr 13, 2024
Merged

Improve docs and add "Also see" section #5

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1bb6598
Improve docs
ozars Apr 13, 2024
8de082d
Add also see section and refer to castaway
ozars Apr 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ Let's say you are implementing a deserializer. There might be certain types
that work well with your own deserializer, while they have a default
implementation for generic deserializers (or even `unimplemented!` by default).

To simplify the example, we will create a water-down version of relevant
To simplify the example, we will create a watered-down version of relevant
`serde` traits.

```rust
Expand Down Expand Up @@ -231,6 +231,7 @@ impl<'de> Deserialize<'de> for MyAwesomeNode {
unimplemented!()
},
fn (mut deserializer: MyAwesomeDeserializer) => {
// We can call a method from the concrete implementation here!
deserializer.my_awesome_function()
},
deserializer
Expand Down Expand Up @@ -279,3 +280,10 @@ compiler errors and in some cases Internal Compiler Errors (ICE). See TODO in
This is very likely due to underlying `min_specialization` implementation not
being very mature yet, though it's quite possible I botched something somewhere
(Please file an issue if you figure out which :P).

## Also see

- [sagebind/castaway](https://github.com/sagebind/castaway): Safe, zero-cost
downcasting for limited compile-time specialization. This is an awesome
library I've just stumbled upon, which seems to be doing what is done here in
a more robust and stable way.
Loading