Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API updates #102

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

API updates #102

wants to merge 5 commits into from

Conversation

augustuswm
Copy link
Contributor

@augustuswm augustuswm commented Jan 9, 2025

Updates the RFD site to use the updated endpoints in: oxidecomputer/rfd-api#243 . Preview will not currently work until I have a test version of the API PR available.

The primary differences here for the site are:

  1. Changes to permission naming
  2. Using npm package for API client instead of endpoint strings
  3. RFD's are no longer guarantee to return a revision. The API may return a minimal set of metadata for an RFD if it is in the middle of creating / storing a new RFD. This is not new a new behavior, it is just properly represented in the API now. It is an extremely rare case.

Still a couple outstanding types errors to fix

Copy link

vercel bot commented Jan 9, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
rfd-site ✅ Ready (Inspect) Visit Preview Jan 15, 2025 10:44am

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license-eye has totally checked 141 files.

Valid Invalid Ignored Fixed
86 4 51 0
Click to see the invalid file list
  • app/services/github-discussion.server.ts
  • app/services/rfd.local.server.ts
  • app/services/rfd.remote.server.ts
  • app/services/rfd.server.ts

app/services/github-discussion.server.ts Show resolved Hide resolved
app/services/rfd.local.server.ts Show resolved Hide resolved
app/services/rfd.remote.server.ts Show resolved Hide resolved
app/services/rfd.server.ts Show resolved Hide resolved
@augustuswm
Copy link
Contributor Author

Build failure is peer dependency conflict with @oxide/design-system. Tracking in oxidecomputer/design-system#106

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants