Brings in vhdl style formatter. #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #142 |
nathanaelhuffman
force-pushed
the
vhdl-style
branch
from
1aa32b6 to
5c135db
Compare
There was a problem hiding this comment.
I left some comments on things I'd like to see changed. I'm not sure if they were preferences you had, or tool defaults. Happy to discuss as you see fit! These were the only things that jumped out at me in a visceral way as I scrolled through. I'm sure there will be more points to discuss as we live with this code and style. It sure is nice to look at consistently formatted files though!!
One thing I would like to understand more is the inconsistency with when there is a space between generic ( and not between generic map( (same goes for port). I have a slight preference for the space, but either way I'd just like to see us consistent in both cases.
Aaron-Hartwig
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can be run via buck:
buck2 run //tools/multitool:multitool -- formator if you just want the report without the fixes:buck2 run //tools/multitool:multitool -- format --no-fixI'll update the README before merging if we're happy with this interface and the application of the rules.
I'm interested in feedback on both the tool interface, and the application of the style rules