Ignition: Make (reset) button acts as power button when system power off #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arjenroodselaar
commented
May 25, 2023
| // than a reset button. The system power transition logic will | ||
| // clear the abort flag is this power off was in response to a | ||
| // system power fault/abort. | ||
| let request_ = system_power_off ? |
There was a problem hiding this comment.
The actual change is here. The remaining fluff is to make the tests work.
Aaron-Hartwig
approved these changes
May 25, 2023
nathanaelhuffman
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing rev C and stumbling over #94 I realized that when the button is configured as reset button, unless a power abort occurred, its events are ignored if the system is powered off. This diff changes this behavior, allowing the button to always power on a system in off state when pressed.
This is not super relevant for the rack because the button is not accessible when systems are installed in cubbies, but it may cause confusion when using systems on a bench an using both the LVDS and button interfaces.