Skip to content

Toward portability #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Mar 28, 2024
Merged

Toward portability #235

merged 10 commits into from
Mar 28, 2024

Conversation

david-crespo
Copy link
Collaborator

@david-crespo david-crespo commented Mar 28, 2024

Lots of little bits progress toward #232. The main things are

  • All process.argv stuff happens at the very top level, with relative path destination dir arg resolved to absolute paths immediately (relative to cwd) and passed down the call chain
  • IO init happens inside generator functions instead of at module top level
  • Static files we copy over are resolved relative to the script's location rather than CWD, which means we can call the script directly from anywhere without having to get weird with npm run --prefix
  • Use tsx instead of esbuild-register to run the thing, mostly because I ran into an error when trying to use import.meta.url and didn't feel like figuring it out with a tool I don't even like

@david-crespo david-crespo merged commit 91b40c6 into main Mar 28, 2024
@david-crespo david-crespo deleted the toward-portability branch March 28, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant