Enforce sprockets measurements#9938
Open
labbott wants to merge 1 commit into
Open
Conversation
labbott
changed the title
Contributor
Author
|
Contributor
Author
|
Changed this to 21 |
labbott
force-pushed
the
labbott/sprockets_enforce
branch
from
daae34f to
5967404
Compare
labbott
changed the title
labbott
force-pushed
the
labbott/sprockets_enforce
branch
3 times, most recently
from
ae3b6c2 to
0024df7
Compare
Contributor
Author
|
I gave this another quick round of testing and it seems to work. I expect we're going to get more mileage out of merging it. |
Sprockets is currently in warning only mode for measurements. This change makes sprockets reject connections if the references measurements aren't as expected. Being able to turn this on/off with a sled-agent config is still a security gap as tech port access can defeat this. It's still useful to have this as a backup option for a little while longer since a failure here will prevent the control plane from coming up. The eventual plan will to change sprockets to be always enforcing regardless of the config. When measurements are enforced we need a (relatively) easy way to allow testing of engineering builds of the SP that need the full control plane. A good example would be a change in the SP to collect sensor data in the control plane. This also adds a tool to take care of adusting the measurement manifest on the `install` dataset. This restricts testing to MUPdate cases but if you need to test reconfigurator with an engineering SP build you are better off making a full TUF repo.
labbott
force-pushed
the
labbott/sprockets_enforce
branch
from
0024df7 to
5c432de
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sprockets is currently in warning only mode for measurements. This
change makes sprockets reject connections if the references measurements
aren't as expected. Being able to turn this on/off with a sled-agent
config is still a security gap as tech port access can defeat this.
It's still useful to have this as a backup option for a little
while longer since a failure here will prevent the control plane
from coming up. The eventual plan will to change sprockets to be always
enforcing regardless of the config.
When measurements are enforced we need a (relatively) easy way
to allow testing of engineering builds of the SP that need the full
control plane. A good example would be a change in the SP to collect
sensor data in the control plane. This also adds a tool to take care
of adusting the measurement manifest on the
installdataset. Thisrestricts testing to MUPdate cases but if you need to test
reconfigurator with an engineering SP build you are better off
making a full TUF repo.