blueprint_loader: Add LoadedTargetBlueprint type
#9496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgallagher
added a commit
that referenced
this pull request
Dec 9, 2025
Tiny cleanup opportunity I noticed while implementing #9496 - we don't need to store a separate "most recently loaded" field (and update it in sync with our watch channel) because we can _just look in the watch channel_.
davepacheco
approved these changes
Dec 10, 2025
jgallagher
force-pushed
the
john/blueprint-into-planning-input
branch
from
a301b6d to
905cb46
Compare
jgallagher
force-pushed
the
john/loaded-blueprint
branch
from
8816932 to
9d7e1da
Compare
jgallagher
added a commit
that referenced
this pull request
Dec 11, 2025
Tiny cleanup opportunity I noticed while implementing #9496 - we don't need to store a separate "most recently loaded" field (and update it in sync with our watch channel) because we can _just look in the watch channel_.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the
(BlueprintTarget, Arc<Blueprint>)tuple as suggested by @davepacheco in #9481 (review).(Also does some minor cleanup to avoid having the
blueprint_plannertask expose a different channel with the same type of contents as theblueprint_loader, with a comment explaining the difference.)Staged on top of #9481.