[support bundle] Add perfetto tracing to bundle collection #9482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hawkw
approved these changes
Dec 5, 2025
Comment on lines
1091
to
1109
| json!({ | ||
| "name": step.name, | ||
| "cat": "bundle_collection", | ||
| "ph": "X", // Complete event (has duration) | ||
| "ts": start_us, | ||
| "dur": duration_us, | ||
| "pid": 1, | ||
| "tid": step_id, | ||
| "args": { | ||
| "status": step.status.to_string(), | ||
| } | ||
| }) | ||
| }) | ||
| .collect(); | ||
|
|
||
| let trace_json = json!({ | ||
| "traceEvents": trace_events, | ||
| "displayTimeUnit": "ms", | ||
| }); |
Member
There was a problem hiding this comment.
not a blocker but: i wonder if we might at some point want a struct deriving serde::Serialize for this, perhaps not in the support bundle collector module, so that we can emit similar Perfetto traces for other operations...
Collaborator
Author
There was a problem hiding this comment.
I started with pulling this into a sub-module that's local to support bundles in 4714a78 - but happy to pull this out more broadly as a follow-up?
(I'm gonna probably break up this support bundle code into some smaller modules in a follow-up PR)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the last step of bundle collection: turn all bundle collection steps into a perfetto-formatted trace file, and stash it in "meta/trace.json".
The cost here is small, and this allows us to easily inspect bundle collection time.
Example output, visualized at ui.perfetto.dev: