Skip to content

Conversation

jmcarp
Copy link
Contributor

@jmcarp jmcarp commented Oct 21, 2025

As a follow-up to #9183, update the replicated_max_ratio_of_wrong_parts setting in the relevant file. After merging the previous PR, we noticed that the change there didn't propagate to the config file in use on the rack. This patch applies that same update to the correct config file in smf/.

As a follow-up to #9183, update the replicated_max_ratio_of_wrong_parts setting
in the relevant file. After merging the previous PR, we noticed that the change
there didn't propagate to the config file in use on the rack. This patch
applies that same update to the correct config file in smf/.
@jmcarp jmcarp requested a review from bnaecker October 21, 2025 14:40
@jmcarp
Copy link
Contributor Author

jmcarp commented Oct 21, 2025

Note: I'm confused about how this runs on the rack. Previously I updated the config file generation code in clickhouse-admin, but that doesn't seem to have changed anything on the rack. And the clickhouse running on the rack appears to be managed by smf, with its config file matching smf/clickhouse/config.xml. Are we using clickhouse-admin to generate config files and run clickhouse—in which case I would expect clickhouse to use a replica-server-config.xml config file generated by clickhouse-admin—or are we using the static config file from smf?

cc @bnaecker @karencfv

@andrewjstone
Copy link
Contributor

Note: I'm confused about how this runs on the rack. Previously I updated the config file generation code in clickhouse-admin, but that doesn't seem to have changed anything on the rack. And the clickhouse running on the rack appears to be managed by smf, with its config file matching smf/clickhouse/config.xml. Are we using clickhouse-admin to generate config files and run clickhouse—in which case I would expect clickhouse to use a replica-server-config.xml config file generated by clickhouse-admin—or are we using the static config file from smf?

cc @bnaecker @karencfv

I think the original PR made the right change. Unfortunately you may have found a gap in our implementation. The reconfigurator planner generates cluster configurations for new clusters but that only deals in the most basic of configurations. The actual clickhouse config only gets generated from the template by clickhouse-admin on zone-deploy I believe. My guess is that expunging and then re-adding servers one by one would get the updated config. This is deeply unsatisfying, but we don't model clickhouse configuration in blueprints and so there is no way to tell that it changed.

I'm not sure why you are seeing the static config from smf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants