Skip to content

nexus: update InstanceCreate documentation #8192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2025

Conversation

sudomateo
Copy link
Contributor

Updated the documentation for the InstanceCreate fields disks and boot_disk to better clarify what they are and the implications of configuring them.

Closes #8089.

Copy link
Member

@iximeow iximeow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for adjusting these docs! a few minor thoughts, but generally 👀 👀

@sudomateo sudomateo force-pushed the sudomateo/instance-create-docs branch 2 times, most recently from 0746bf6 to c38a589 Compare May 22, 2025 12:06
@sudomateo sudomateo force-pushed the sudomateo/instance-create-docs branch from c38a589 to 0a87141 Compare May 22, 2025 18:39
Copy link
Contributor

@david-crespo david-crespo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, thanks!

@sudomateo sudomateo force-pushed the sudomateo/instance-create-docs branch from 0a87141 to 3651697 Compare May 22, 2025 19:41
@sudomateo
Copy link
Contributor Author

Doh! Forgot to run cargo xtask openapi generate. Did that now.

@sudomateo sudomateo enabled auto-merge (squash) May 22, 2025 19:48
Updated the documentation for the `InstanceCreate` fields `disks` and
`boot_disk` to better clarify what they are and the implications of
configuring them.

Closes #8089.
@sudomateo sudomateo force-pushed the sudomateo/instance-create-docs branch from 3651697 to 9f949c9 Compare May 23, 2025 04:23
@sudomateo sudomateo merged commit 3ddcae2 into main May 23, 2025
17 checks passed
@sudomateo sudomateo deleted the sudomateo/instance-create-docs branch May 23, 2025 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nexus: Clarify disks and boot_disk in instance create
3 participants