nexus: update InstanceCreate documentation#8192
Merged
Conversation
iximeow
reviewed
May 21, 2025
Member
iximeow
left a comment
iximeow
left a comment
There was a problem hiding this comment.
thanks for adjusting these docs! a few minor thoughts, but generally 👀 👀
sudomateo
force-pushed
the
sudomateo/instance-create-docs
branch
2 times, most recently
from
0746bf6 to
c38a589
Compare
iximeow
reviewed
May 22, 2025
sudomateo
force-pushed
the
sudomateo/instance-create-docs
branch
from
c38a589 to
0a87141
Compare
sudomateo
force-pushed
the
sudomateo/instance-create-docs
branch
from
0a87141 to
3651697
Compare
Contributor
Author
|
Doh! Forgot to run |
Updated the documentation for the `InstanceCreate` fields `disks` and `boot_disk` to better clarify what they are and the implications of configuring them. Closes #8089.
sudomateo
force-pushed
the
sudomateo/instance-create-docs
branch
from
3651697 to
9f949c9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the documentation for the
InstanceCreatefieldsdisksandboot_diskto better clarify what they are and the implications of configuring them.Closes #8089.