[nexus] support bundle diag commands should be saved in json #7462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.6-beta.1
smklein
reviewed
Jan 31, 2025
| ) | ||
| .await?; | ||
| let json = serde_json::to_string(&output)?; | ||
| tokio::fs::write(path.join(format!("{command}.txt")), json).await?; |
There was a problem hiding this comment.
Should we use a .json suffix here?
Related: Do we want the error types to be serialized to JSON too?
There was a problem hiding this comment.
Fixed in e610f80
I am inclined to leave the error file alone as I feel like most of the structured output parsing will happen on the "success" path where there may be multiple commands that have ran with output that you would like to filter through.
wfchandler
reviewed
Feb 3, 2025
Created using spr 1.3.6-beta.1
wfchandler
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Diagnostic commands now output the json serialized value rather than the debug output for the inner type.
This is on top of: