Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

convert to new dropshot builder interface #6730

Merged
merged 21 commits into from
Nov 14, 2024
Merged

convert to new dropshot builder interface #6730

merged 21 commits into from
Nov 14, 2024

Conversation

davepacheco
Copy link
Collaborator

@davepacheco davepacheco commented Sep 30, 2024 •
edited
Loading

This updates all Dropshot consumers in Omicron to use the new ServerBuilder interface instead of the old HttpServerStarter interface.

(This PR started as part of oxidecomputer/dropshot#1122. Although that should be a non-breaking change, I wanted to test-convert all of Omicron over to the new thing to make sure I didn't run into any unexpected issues. This worked out pretty well (and there were no callers that didn't immediately invoke start() on the HttpServerStarter).)

@davepacheco davepacheco mentioned this pull request Sep 30, 2024
Merged
@davepacheco
Copy link
Collaborator Author

davepacheco commented Oct 1, 2024 •
edited
Loading

For the record, this can't run in CI due to the local patch, but cargo xtask clippy and cargo nextest run --no-fail-fast were clean on commit c0ea923. Updated.

@davepacheco
test build for dropshot + API versioning
c7c0f3e
@davepacheco
rustfmt
fe3331e
@davepacheco
fix expectorate
3a17ac3
@davepacheco
fix test failure in integration_tests::updates::test_update_uninitial…
fd95b56 
…ized
@davepacheco
minimum changes for Dropshot v0.13.0
c4e7281
@davepacheco
avoid tight coupling with propolis Dropshot version
6806e0b
@davepacheco
does not need to be async
97d7d4d
@davepacheco
update dep
3da800b
@davepacheco
update Cargo.lock
294caf7
@davepacheco
Merge remote-tracking branch 'origin/dap/fix-dropshot-coupling' into …
5183381 
…dap/drafts/dropshot-update
@davepacheco
update Propolis for mock server updates
25d67e7
@davepacheco
Merge branch 'dap/propolis-update' into dap/fix-dropshot-coupling
afa4f8b
@davepacheco
update Cargo.lock too
d94c953
@davepacheco
Merge branch 'dap/propolis-update' into dap/fix-dropshot-coupling
9380f0b
@davepacheco
Merge remote-tracking branch 'origin/dap/fix-dropshot-coupling' into …
35f0467 
…dap/drafts/dropshot-update
@davepacheco davepacheco mentioned this pull request Nov 13, 2024
Merged
@davepacheco davepacheco changed the title prototype conversion to new dropshot builder interface convert to new dropshot builder interface Nov 13, 2024
@davepacheco davepacheco changed the base branch from main to dap/drafts/dropshot-update November 13, 2024 21:37
@davepacheco davepacheco force-pushed the dap/dropshot-builder branch 2 times, most recently from 7841c5b to 534f0fe Compare November 13, 2024 21:41
Base automatically changed from dap/drafts/dropshot-update to main November 14, 2024 02:50
@davepacheco davepacheco marked this pull request as ready for review November 14, 2024 02:53
sunshowers
sunshowers approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@sunshowers sunshowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!

@davepacheco davepacheco enabled auto-merge (squash) November 14, 2024 16:06
@davepacheco davepacheco merged commit 7cf2b90 into main Nov 14, 2024
16 checks passed
@davepacheco davepacheco deleted the dap/dropshot-builder branch November 14, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunshowers sunshowers sunshowers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davepacheco @sunshowers