[nexus] don't retry on non-retryable errors in some tests#10720
Open
sunshowers wants to merge 1 commit into
Open
[nexus] don't retry on non-retryable errors in some tests#10720sunshowers wants to merge 1 commit into
sunshowers wants to merge 1 commit into
Conversation
Created using spr 1.3.6-beta.1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of chasing down #10697. It looks like some other Dropshot service is grabbing this port in the interim. But we spin for the full 60 seconds when that happens (and we receive a 400), even though we can just fail right away.
This doesn't address the underlying issue, but at least makes our test runs that much faster when it happens.