Oximeter: Expose kind in ProducerDetails and plumb to omdb.#10715
Open
jmcarp wants to merge 1 commit into
Open
Oximeter: Expose kind in ProducerDetails and plumb to omdb.#10715jmcarp wants to merge 1 commit into
kind in ProducerDetails and plumb to omdb.#10715jmcarp wants to merge 1 commit into
Conversation
I noticed that `omdb oximeter list-producers` and `omdb oximeter producer-details` both omit the `kind` of each producer. This can be useful to show! This patch adds `kind` to `ProducerDetails`, so that we can plumb it to `omdb oximeter producer-details`, adding a new oximeter api version in the process. We also expose the existing `kind` field of `ProducerEndpoint` to `omdb oximeter list-producers`.
jmcarp
force-pushed
the
jmcarp/omdb-producer-kind
branch
from
dff0dc1 to
fb4894e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that
omdb oximeter list-producersandomdb oximeter producer-detailsboth omit thekindof each producer. This can be useful to show! This patch addskindtoProducerDetails, so that we can plumb it toomdb oximeter producer-details, adding a new oximeter api version in the process. We also expose the existingkindfield ofProducerEndpointtoomdb oximeter list-producers.