Skip to content

Commit

Permalink
Document IDP key format requirement
Browse files Browse the repository at this point in the history
We currently require SAML private keys to be in RSA PKCS#1 format, but
do not mention this in our doc string.

Update the doc string to explicitly list the required format.
  • Loading branch information
wfchandler committed Nov 18, 2024
1 parent 8a6182a commit b813310
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion nexus/types/src/external_api/params.rs
Original file line number Diff line number Diff line change
Expand Up @@ -584,7 +584,7 @@ pub struct DerEncodedKeyPair {
#[serde(deserialize_with = "x509_cert_from_base64_encoded_der")]
pub public_cert: String,

/// request signing private key (base64 encoded der file)
/// request signing RSA private key in PKCS#1 format (base64 encoded der file)
#[serde(deserialize_with = "key_from_base64_encoded_der")]
pub private_key: String,
}
Expand Down
2 changes: 1 addition & 1 deletion openapi/nexus.json
Original file line number Diff line number Diff line change
Expand Up @@ -13217,7 +13217,7 @@
"type": "object",
"properties": {
"private_key": {
"description": "request signing private key (base64 encoded der file)",
"description": "request signing RSA private key in PKCS#1 format (base64 encoded der file)",
"type": "string"
},
"public_cert": {
Expand Down

0 comments on commit b813310

Please sign in to comment.