bgp: remember to delete router from db #516
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the delete_router API endpoint was called, the router was not fully
being deleted. "mgadm bgp config router list" would still display a
router despite returning a 204 No Content indicating the operation was
successful:
```
[trey@zebes:~/git/maghemite on main]
% ./target/debug/mgadm bgp config router list
[
Router {
asn: 1,
graceful_shutdown: false,
id: 1,
listen: "[::]:179",
},
]
[trey@zebes:~/git/maghemite on main]
% ./target/debug/mgadm bgp config router delete 1
[trey@zebes:~/git/maghemite on main]
% ./target/debug/mgadm bgp config router list
[
Router {
asn: 1,
graceful_shutdown: false,
id: 1,
listen: "[::]:179",
},
]
```
This is because the API handler would remove the router from the
BgpContext struct, but not from the persistent sled db.
This change ensures the router is removed from the sled db, not just the
in-memory BgpContext data structure. Now the router gets deleted from
the sled db, and mgadm properly reflects the running state:
```
[trey@zebes:~/git/maghemite on trey/fix_router_del]
% ./target/debug/mgadm bgp config router list
[
Router {
asn: 1,
graceful_shutdown: false,
id: 1,
listen: "[::]:179",
},
]
[trey@zebes:~/git/maghemite on trey/fix_router_del]
% ./target/debug/mgadm bgp config router delete 1
[trey@zebes:~/git/maghemite on trey/fix_router_del]
% ./target/debug/mgadm bgp config router list
[]
```
Signed-off-by: Trey Aspelund <[email protected]>
rcgoodfellow
approved these changes
Jun 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the delete_router API endpoint was called, the router was not fully being deleted. "mgadm bgp config router list" would still display a router despite returning a 204 No Content indicating the operation was successful:
This is because the API handler would remove the router from the BgpContext struct, but not from the persistent sled db.
This change ensures the router is removed from the sled db, not just the in-memory BgpContext data structure. Now the router gets deleted from the sled db, and mgadm properly reflects the running state: