Provide type hint to fix unhinted subparse #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
FelixMcFelix
approved these changes
Jan 31, 2025
mkeeter
added a commit
that referenced
this pull request
Feb 3, 2025
We were previously double-counting nested packet sizes: both in the parent packet's `MINIMUM_SIZE`, and again when calling the inner `packet_size()`. This wasn't an issue when the only nested packets were `Repeated<..>` (with a minimum size of 0), but #16 lets us nest a **single** header within another.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15; otherwise, the
hintfield is never used and the compiler gets mad about not being able to infer its type.