Removed unneeded used_with_arg #2027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I_think_ this is supposed to be used in conjunction with https://github.com/oxidecomputer/hubris/blob/master/test/test-suite/src/main.rs#L50-L65 |
|
@labbott yeah but there's already https://github.com/oxidecomputer/hubris/blob/master/test/test-suite/src/main.rs#L21 on that file... unless you need it here too for this to work? Anyway, mostly was just checking in on some things, if we'd rather leave this here just to make sure nothing breaks, not the end of the world, was just curious |
labbott
approved these changes
Mar 11, 2025
steveklabnik
force-pushed
the
used-with-arg
branch
from
2415aea to
7ee4936
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm actually not 100% sure this isn't needed here, but it appears vestigial, so let's give it a CI run.