Need LRDIMM support in APCB config #186
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helios#185 Fix image template RDIMM PMU config
|
I have finished all the various testing I intended here so I think this is ready for review from someone. |
citrus-it
approved these changes
Jan 24, 2025
There was a problem hiding this comment.
I've compared what's here with what I see dumping the RXM100AB.FD file in Milan 1.0.0.a (grepping out _reserved and converting things to hex to make it easier), and as far as I can tell it matches. Given it works experimentally, I think it's fine!
If @daym has a chance to look it over I think that would be useful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This covers the LRDIMM support in #184 and #185. Note, I do not plan to merge this until we finish validation. The data here is system agnostic and you can verify that by comparing this to the various stock pieces that AMD provides in AGESA.