softnpu: fix router v6 keyset data #129
Conversation
| serialize_value_type(&x, &mut data); | ||
| keyset_data.extend_from_slice(&data[..2]); | ||
| } | ||
| ROUTER_V6_RT => { |
There was a problem hiding this comment.
Huh. How did I get this up on a4x2 if ipv6 routing doesn't work?
There was a problem hiding this comment.
Things break non-deterministically. See the comments here. Sometimes CI in that PR works, sometimes it does not. I'm not sure if this is the cause yet. Still trying to determine where the inconsistency is creeping in.
There was a problem hiding this comment.
This is not the cause of the issue in oxidecomputer/maghemite#545. I can reproduce the issue with this patch.
There was a problem hiding this comment.
The root cause for the flaky behavior I was seeing in CI has been identified. This was due to restarting dpd while keeping underlying state around in softnpu. The following ticket has been filed for this.
And until that gets done oxidecomputer/maghemite#545 is not restarting dendrite during its test runs.
No description provided.